HOTFIX: Fix GroupMetadataManager#completeAlterShareGroupOffsets to use InitMapValue in addInitializingTopicsRecords#19792
Merged
apoorvmittal10 merged 4 commits intoMay 23, 2025
Conversation
chia7712
reviewed
May 23, 2025
mingyen066
changed the title
Yunyung
reviewed
May 23, 2025
Rancho-7
approved these changes
May 23, 2025
apoorvmittal10
approved these changes
May 23, 2025
ShivsundarR
approved these changes
May 23, 2025
FrankYang0529
approved these changes
May 23, 2025
chia7712
approved these changes
May 23, 2025
frankvicky
approved these changes
May 23, 2025
Yunyung
approved these changes
May 23, 2025
m1a2st
approved these changes
May 23, 2025
smjn
reviewed
May 23, 2025
| .map(AlterShareGroupOffsetsRequestData.AlterShareGroupOffsetsRequestPartition::partitionIndex) | ||
| .filter(existingPartitions::contains) | ||
| .collect(Collectors.toSet())); | ||
| initializingTopics.put(topicId, new InitMapValue( |
Collaborator
There was a problem hiding this comment.
Not required:
can call attachInitValues on the map.
Member
There was a problem hiding this comment.
The current version is better because initializingTopics already contains complete information (ID and name), and attachInitValue would create an additional map. WDYT?
Collaborator
brandboat
approved these changes
May 23, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/apache/kafka/pull/19781/files#diff-00f0f81cf13e66781777d94f7d2e68a581663385c37e98792507f2294c91bb09L2746-R2745
changes the
addInitializingTopicsRecordssignature whilehttps://github.com/apache/kafka/pull/18929/files#r2104172356 didn't make
adjustment accordingly.
Fix GroupMetadataManager#completeAlterShareGroupOffsets to use
InitMapValueininitializingTopicsso thataddInitializingTopicsRecordscan accept it.